Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs about integration with each framework #54

Merged
merged 5 commits into from
Jul 22, 2020

Conversation

KingDarBoja
Copy link
Contributor

@KingDarBoja KingDarBoja commented Jul 11, 2020

This pull request fixes #46. Be aware that several options are being added on #55, like as the GraphiQLOptions or Flask context (which was missing).

This is a initial draft of how integration docs would be, in this case, I started with Flask to checkout what else should I put at the other docs, so do not merge yet.

@KingDarBoja KingDarBoja added the type: documentation An issue or pull request for improving or updating the documentation label Jul 11, 2020
@KingDarBoja KingDarBoja requested review from Cito and jkimbo July 11, 2020 22:12
@KingDarBoja KingDarBoja self-assigned this Jul 11, 2020
docs/flask.md Outdated Show resolved Hide resolved
docs/flask.md Show resolved Hide resolved
docs/flask.md Outdated Show resolved Hide resolved
docs/flask.md Outdated Show resolved Hide resolved
docs/flask.md Outdated Show resolved Hide resolved
docs/flask.md Outdated Show resolved Hide resolved
docs/flask.md Outdated Show resolved Hide resolved
@KingDarBoja KingDarBoja requested a review from jkimbo July 12, 2020 20:02
@KingDarBoja KingDarBoja marked this pull request as ready for review July 12, 2020 20:02
@KingDarBoja KingDarBoja added this to the GraphQL-Server (V3) milestone Jul 12, 2020
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change but otherwise looks good 👍

docs/aiohttp.md Outdated Show resolved Hide resolved
@KingDarBoja KingDarBoja requested a review from jkimbo July 20, 2020 16:26
@jkimbo jkimbo merged commit 51dcc22 into graphql-python:master Jul 22, 2020
@KingDarBoja KingDarBoja deleted the documentation-servers branch July 22, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation about how to integrate with different frameworks
2 participants