Use graphql-core-next instead of graphql-core + support async #17
Conversation
add some support for async
There was a problem hiding this comment.
@norman-thomas thanks for contributing this! How do you feel about updating/adding tests to cover the changes in behavior introduced in this branch?
@ProjectCheshire what is your opinion on the question of whether the next version of this library needs to continue supporting py2?
| @@ -1,6 +1,6 @@ | |||
| from setuptools import setup, find_packages | |||
|
|
|||
| required_packages = ["graphql-core>=2.1", "promise"] | |||
| required_packages = ["graphql-core-next>=1.0.2", "promise"] | |||
There was a problem hiding this comment.
Just a question: how did you pick this version to >= for?
| @@ -28,7 +28,7 @@ | |||
| keywords="api graphql protocol rest", | |||
| packages=find_packages(exclude=["tests"]), | |||
| install_requires=required_packages, | |||
| tests_require=["pytest>=2.7.3"], | |||
| tests_require=["pytest>=4.3.1"], | |||
There was a problem hiding this comment.
I don't see in the CR where you're changing or adding tests that use any new features of pytest; why did you bump the version here?
|
Thank you @norman-thomas Unfortunately, I saw it only today - I have also created a branch of graphql-server-core yesterday here that has similar changes. graphql-server-core is actually a helper library for other libraries like flask-graphql. If we make any changes here, we must make sure that these libraries do not get broken or upgrade them as well. In my branch I added tests so that we have 100% code coverage. But some things are still different due to the new API, and tools like flask-grapqhl will need some adaptation, too. Before we proceed I think we need a general versioning policy for the graphql-python tools so that the full stack of tools stays compatible (see graphql-python/graphql-core/issues/241 for that discussion). |
Cito
force-pushed
the
master
branch
2 times, most recently
from
d21bdd4 to
c781f01
Compare
|
Closing as fixed on #36 |
I made some adaptions to use this library together with graphql-core-next
The usage of
async/awaitmay not be desired in this repo for reasons that start with2.x. In that case, feel free to close/ignore.