Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't format exceptions before logging #269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't format exceptions before logging #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions graphql/execution/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# -*- coding: utf-8 -*-
import logging
from traceback import format_exception

from ..error import GraphQLError
from ..language import ast
Expand Down Expand Up @@ -149,10 +148,10 @@ def get_argument_values(self, field_def, field_ast):

def report_error(self, error, traceback=None):
# type: (Exception, Optional[TracebackType]) -> None
exception = format_exception(
type(error), error, getattr(error, "stack", None) or traceback
logger.exception(
error,
exc_info=(type(error), error, getattr(error, "stack", None) or traceback),
)
logger.error("".join(exception))
self.errors.append(error)

def get_sub_fields(self, return_type, field_asts):
Expand Down