pytest: Don't use nose like syntax in graphene/relay/tests/test_custom_global_id.py (#1539) #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests in test_custom_global_id.py use the old nose specific method 'setup(self)' which isn't supported anymore in Pytest 8+. The tests fail with this error message without modification. E pytest.PytestRemovedIn8Warning: Support for nose tests is deprecated and will be removed in a future release. E graphene/relay/tests/test_custom_global_id.py::TestIncompleteCustomGlobalID::test_must_define_resolve_global_id is using nose-specific method: `setup(self)` E To remove this warning, rename it to `setup_method(self)` E See docs: https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose
|
thanks for the pr! |
erikwrede
approved these changes
Jun 13, 2024
This was referenced Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests in test_custom_global_id.py use the old nose specific method 'setup(self)' which isn't supported anymore in Pytest 8+.
https://daobook.github.io/pytest/deprecations.html#setup-teardown