Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decimal type conversion #376

Conversation

jendrikjoe
Copy link
Contributor

With the merge of #371, the conversion of Decimal columns broke for us.
I added a decimal column as we are creating them to the test model reproducing it and a possible fix, by registering the type to the converter.

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 96.36% // Head: 96.36% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (6b036ac) compared to base (d3a4320).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #376   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files           9        9           
  Lines         908      909    +1     
=======================================
+ Hits          875      876    +1     
  Misses         33       33           
Impacted Files Coverage Δ
graphene_sqlalchemy/converter.py 95.83% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erikwrede
Copy link
Member

Sorry for the late reply.
I have received multiple messages about this, so I am considering making changes to the type conversion system introduced in #371 so that we keep supporting the conversion of subclasses of registered classes. This adds a lot of convenience since every driver has custom subtypes for bigint, integer and others.
Please check out #377 to see if that fixes your issues and give me some feedback ☺️
I will add the necessary tests tomorow.

@jendrikjoe
Copy link
Contributor Author

Sorry for the late reply.
I have received multiple messages about this, so I am considering making changes to the type conversion system introduced in #371 so that we keep supporting the conversion of subclasses of registered classes. This adds a lot of convenience since every driver has custom subtypes for bigint, integer and others.
Please check out #377 to see if that fixes your issues and give me some feedback ☺️
I will add the necessary tests tomorow.

No worries. Solving this in a generic way definitely seems reasonable 👍 Will close this one in favor of #377 👍

@jendrikjoe jendrikjoe closed this Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants