-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix enum column conversion by "instantiating" Enum #201
Conversation
d7f9085
to
1d897cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just had a couple of very minor comments.
1d897cb
to
53f107e
Compare
Once this gets merged in, I wouldn't mind resolving the conflicts in #165 with my changes. |
@thejcannon After commented on this PR, I caught up with this one #98. Do you expect your PR to conflict with that one as well? |
Actually I looked at #165 for this issue and made this: thejcannon@737e288 So you could close both of those once that PR is made/merged. |
Closing since #210 got merged |
Fixes #196 and #199.
See also graphql-python/graphene#932