Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Required/NonNull behaviour for Pydantic fields with defaults #84

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Fix the Required/NonNull behaviour for Pydantic fields with defaults #84

merged 1 commit into from
Jul 24, 2023

Conversation

davidkell
Copy link
Contributor

Fixes #48

@davidkell
Copy link
Contributor Author

Looks like the CI config is broken?

@dStass
Copy link

dStass commented Jul 23, 2023

Hi! Would love this PR to be merged - @davidkell are you able to retry these tests? Thanks

@davidkell
Copy link
Contributor Author

@dStass I think we're stuck until the tests are fixed on main, unless @necaris is able to merge without the tests passing

@necaris necaris merged commit 4e219fa into graphql-python:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@necaris necaris necaris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Required/NonNull behaviour for Pydantic fields with defaults
3 participants
@davidkell @dStass @necaris