Feature: Support Union in DjangoFilterConnectionField and DjangoConnectionField #1537
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was previously mentioned here
The purpose of this PR is to make Union types compatible with DjangoFilterConnectionFields so that we can query a root model that is resolved to other model types in runtime, supporting libraries like django-polymorphic
Here's an example of what this PR achieves:
Previously,
DjangoFilterConnectionField
only acceptedDjangoObjectTypes
andDjangoObjectTypes
do not support unions.Has this PR dependancy that needs merging for the feature to work
NOTE: Tests are failing because it depends on the aforementioned PR!