-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync auto batching requests #436
Sync auto batching requests #436
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #436 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 28 28
Lines 2497 2578 +81
=========================================
+ Hits 2497 2578 +81
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tiny change, the rest are question or suggestions. Also, I don't know if we should support the empty list as a valid argument in the requests parameter. If not, we should include an assert in the client
Implementation of an automatic batching of requests for the sync transports.
See issue #430