fix no-duplicate-fields, compare selections with fragment spreads and inline fragments
#975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotansimha
approved these changes
Feb 22, 2022
dimaMachina
added
the
status/parked
saihaj
reviewed
Jan 3, 2023
An example of a false positive? |
saihaj
reviewed
Jan 3, 2023
Comment on lines
+56
to
+65
| users { | ||
| id | ||
| ...UserFullFields # email #email | ||
| name #3 | ||
| ...UserFields # email firstName | ||
| ... on User { | ||
| id #6 | ||
| name #7 | ||
| email #8 | ||
| } |
There was a problem hiding this comment.
@B2o5T imagine for some nested UI components it is likely you are using UserFullFields in one place and UserFields in some other place and it can actually be a valid use case but this rule would mark that as error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.