Fix report lint issues not on first char of file for .vue and support ESLint fixes and suggestions
#2735
Conversation
🦋 Changeset detectedLatest commit: 253e17c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| processorVueBlocks({ | ||
| blocks: { | ||
| styles: false, | ||
| customBlocks: true, |
There was a problem hiding this comment.
should I remove processing custom blocks? @bmulholland
There was a problem hiding this comment.
I didn't even know you could do that! They sound cool... and like something that should be out of scope for now.
They're custom, so you'd want to pretty careful with the scenario. Best for someone to have the need and share what it is in more detail. That would probably be a very long tail thing though... honestly probably can always ignore.
| @@ -2,8 +2,6 @@ | |||
| <span>test</span> | |||
| </template> | |||
| <script> | |||
| /* eslint-disable no-unused-vars */ | |||
There was a problem hiding this comment.
I only found one bug, can't understand but the ESLint directives no longer works in script tags
If I have this directive I have
If I remove
There was a problem hiding this comment.
Yeah it wouldn't be the first time I see a lint disabling a rule and also disabling the unused-directive check hah.
You could easily just use the variables, though. I'll post code above.
There was a problem hiding this comment.
nope, because it's upstream issue from merge-processors antfu/eslint-processor-vue-blocks#8 (comment)
dimaMachina
changed the title
dimaMachina
changed the title
.vue and support ESLint fixes and suggestions
| blocks: { | ||
| styles: false, | ||
| customBlocks: true, | ||
| script: true, |
There was a problem hiding this comment.
also what about this scriptSetup
There was a problem hiding this comment.
Script setup is essentially the new standard, best practice way to write Vue components. Almost all my code is in that, or migrating to it. Should certainly be supported.
|
Oh wow this is really exciting! I'll take a look :) |
|
Nice find on that package! If you think this is ready, I can try it out on my project. I always struggle with trying unpackaged JS libraries (spoiled by Ruby, I suppose). Could I just clone this branch and use |
graphql-eslint needs a new alpha release to try it out, I will do it in few minutes with bug fix you will need just update your project according new vue example |
💻 Website PreviewThe latest changes are available as preview in: https://2277a208.graphql-eslint.pages.dev |
fixes #2103
cc @bmulholland