[new rule] validate subgraph according federation 2 #2049
Conversation
|
| "peerDependenciesMeta": { | ||
| "@apollo/federation-internals": { | ||
| "optional": true | ||
| } | ||
| }, |
There was a problem hiding this comment.
I think people should explicitly install this dependency if they want to validate federation schema, there is no need to add to dependencies
| } from '@apollo/federation-internals'; | ||
| import { GraphQLESLintRule } from '../types.js'; | ||
|
|
||
| const RULE_ID = 'federation-subgraph'; |
There was a problem hiding this comment.
any suggestions to rule name?
There was a problem hiding this comment.
apollo-federation-subgraph would be more precise?
| "@apollo/federation-internals": { | ||
| "optional": true | ||
| } | ||
| }, | ||
| "dependencies": { | ||
| "@graphql-tools/code-file-loader": "^8.0.0", | ||
| "@graphql-tools/graphql-tag-pluck": "^8.0.0", |
There was a problem hiding this comment.
maybe we should add @graphql-tools/graphql-tag-pluck also to peerDependencies in v4, since it's a big dependency that installs a lot of things (not everybody lint code files)
|
What's needed to move this forward? |
Part of #1824
I am new in the Federation spec and feel like validation should be split into 2 rules