Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tailcall added #210

Closed
wants to merge 7 commits into from
Closed

feat: tailcall added #210

wants to merge 7 commits into from

Conversation

Dhanus3133
Copy link
Contributor

Added Tailcall

sc231997
sc231997 reviewed Nov 2, 2023
View reviewed changes
tailcall/tailcall.sh Outdated Show resolved Hide resolved
@Dhanus3133 Dhanus3133 changed the title feat: tailcall v0.13 feat: tailcall added Nov 2, 2023
tusharmath
tusharmath reviewed Nov 3, 2023
View reviewed changes
tailcall/hello.graphql Outdated Show resolved Hide resolved
@tusharmath
Copy link

Where can we see the benchmark results?

@sc231997
Copy link

sc231997 commented Nov 3, 2023

Where can we see the benchmark results?

image
https://github.com/graphql-crystal/benchmarks/actions/runs/6736714074/job/18312641720?pr=210

tusharmath
tusharmath reviewed Nov 3, 2023
View reviewed changes
benchmarks.yaml Outdated Show resolved Hide resolved
@Dhanus3133
fix: requested changes
57a73c7
@Dhanus3133
build: changed the order for graphql-ruby
784ecc5 
This cases error sometimes
```
/home/runner/work/benchmarks/benchmarks/graphql-ruby: command 'bundle' failed with exit code 1
```
tusharmath
tusharmath reviewed Nov 3, 2023
View reviewed changes
benchmarks.yaml
"2",
"-b",
"tcp://127.0.0.1:8000",
]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should we disable graphql-ruby?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't disable but reordered it

tusharmath
tusharmath reviewed Nov 3, 2023
View reviewed changes
benchmarks.yaml
"-Xmx4G",
"-jar",
"./target/scala-2.13/sangria-assembly-0.1.0-SNAPSHOT.jar",
]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should we disable sangria?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action

Check this one, it just halts there on sangria

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgillich could comment on it.

tusharmath
tusharmath reviewed Nov 3, 2023
View reviewed changes
benchmarks.yaml
"-b",
"tcp://127.0.0.1:8000",
]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why re-order the servers?

Copy link
Contributor Author

@Dhanus3133 Dhanus3133 Nov 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check this one Action

Also quite some more PR's have been failed due to this

/home/runner/work/benchmarks/benchmarks/graphql-ruby: command 'bundle' failed with exit code 1

So I reordered it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I'm not quite sure, that reordering can fix that problem all time.

@tusharmath
Copy link

For reference here is the generated README.md

Results

Name Language Server Latency avg Requests
static-rust Rust Actix Web 1.22ms 82kps
tailcall No Code Tailcall 2.33ms 43kps
graphql-crystal Crystal Kemal 2.83ms 35kps
Juniper Rust Actix Web 2.90ms 34kps
async-graphql Rust Actix Web 2.96ms 34kps
gqlgen Go net/http 3.26ms 31kps
Mercurius Node.js Fastify 5.93ms 17kps
Hot Chocolate C# ASP.NET 7.02ms 14kps
agoo Ruby/C agoo 7.92ms 13kps
graphql-go Go net/http 8.47ms 12kps
graphql-yoga Node.js http 11.76ms 8.5kps
Hono Bun HonoJS 13.05ms 7.7kps
graphql-jit Node.js http 17.44ms 5.7kps
Absinthe Elixir Phoenix 18.30ms 5.5kps
apollo Node.js Express 24.41ms 4.1kps
graphql-ruby Ruby Puma 39.82ms 3.2kps
graphql-js Node.js http 34.32ms 2.9kps
Strawberry Python gunicorn 83.02ms 1.2kps
Graphene Python gunicorn 83.47ms 1.2kps

@tusharmath tusharmath mentioned this pull request Nov 3, 2023
Closed
@jgillich
Copy link
Member

jgillich commented Nov 7, 2023

I'd prefer an installation method that uses a fixed version. Can we switch to installing from npm via a package.json instead? Thanks

jgillich
jgillich reviewed Nov 7, 2023
View reviewed changes
benchmarks.yaml
name: tailcall
url: https://github.com/tailcallhq/tailcall
lang: No Code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust

@tusharmath tusharmath mentioned this pull request Nov 8, 2023
Closed
@jgillich
Copy link
Member

jgillich commented Nov 8, 2023

Hmm, the @tailcallhq/tailcall package does nothing for me. And when I try to install it directly, I get an error:

$ npm i @tailcallhq/core-linux-x86_64-gnu
npm ERR! code EBADPLATFORM
npm ERR! notsup Unsupported platform for @tailcallhq/[email protected]: wanted {"os":"linux-gnu","cpu":"x86_64"} (current: {"os":"linux","cpu":"x64"})
npm ERR! notsup Valid os:   linux-gnu
npm ERR! notsup Actual os:  linux
npm ERR! notsup Valid cpu:  x86_64
npm ERR! notsup Actual cpu: x64

linux-gnu and linux-musl aren't a thing according to https://nodejs.org/api/process.html#processplatform

@jgillich jgillich closed this in 3c304a7 Nov 8, 2023
@jgillich jgillich mentioned this pull request Nov 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc231997 sc231997 sc231997 left review comments

@jgillich jgillich jgillich left review comments

@tusharmath tusharmath tusharmath left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dhanus3133 @tusharmath @sc231997 @jgillich