Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[debug]Graph Util function #745

Merged
merged 12 commits into from
Sep 26, 2024

Conversation

KUcyans
Copy link
Collaborator

@KUcyans KUcyans commented Sep 10, 2024

The function gather_cluster_sequence is used to cluster the data that have the same combination of values in the selected column(s).

  • The previous implementation works only for the column selection starting from index 0.
  • Now a user can use any column indices for the clustering.
    • the indices don't have to start with 0
  • The variable name has changed from sort_this to contingency_table for the sake of readability

Cyan and others added 2 commits September 10, 2024 11:43
@KUcyans
Copy link
Collaborator Author

KUcyans commented Sep 10, 2024

I changed the argument for numpy arange to make cluster_columns_contingency_table

@RasmusOrsoe
Copy link
Collaborator

@KUcyans Black will automatically format these things for you locally when you commit. Consider installing pre-commit - it will save you a lot of time. More info here: https://graphnet-team.github.io/graphnet/contribute/contribute.html#code-quality

@KUcyans
Copy link
Collaborator Author

KUcyans commented Sep 20, 2024

@RasmusOrsoe I finally know I should have run pre-commit before I finalise my changes. This integration system is very advanced and cool to me. Thanks for letting me know.

…iable names are misused in the process of reducing the variable name
@KUcyans KUcyans self-assigned this Sep 24, 2024
@KUcyans KUcyans assigned KUcyans and unassigned KUcyans Sep 25, 2024
Copy link
Collaborator

@RasmusOrsoe RasmusOrsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thanks for this clean contribution @KUcyans

@KUcyans KUcyans merged commit 6309445 into graphnet-team:main Sep 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants