Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused modules #732

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Remove unused modules #732

merged 2 commits into from
Aug 7, 2024

Conversation

AlexKurek
Copy link
Contributor

No description provided.

@RasmusOrsoe
Copy link
Collaborator

@AlexKurek thank you for this contribution!

The PR checks fail here because of a numpy version issue that is unrelated to your changes. This issue has recently been fixed in main. Could you update this PR with the recent changes from main, so we can re-run the checks?

@AlexKurek
Copy link
Contributor Author

@RasmusOrsoe Ok, done.

@RasmusOrsoe RasmusOrsoe self-requested a review August 6, 2024 06:23
Copy link
Collaborator

@RasmusOrsoe RasmusOrsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexKurek thank you very much for this contribution! 🚀

@RasmusOrsoe RasmusOrsoe merged commit 3a34edb into graphnet-team:main Aug 7, 2024
14 checks passed
@AlexKurek
Copy link
Contributor Author

Consider using some linter, eg. VS Code + Pylance and Ruff plugins. It will show you such things automatically.

@RasmusOrsoe RasmusOrsoe mentioned this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants