Update CONTRIBUTING.md #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RasmusOrsoe
approved these changes
Sep 5, 2023
RasmusOrsoe
pushed a commit
to RasmusOrsoe/graphnet
that referenced
this pull request
Oct 25, 2023
…TING.md Update CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a typo in
CONTRIBUTING.mdwhich has been fixed.CONTRIBUTING.mdalso contained references to GraphBuilder which were removed in #558. The example has been replaced with GraphDefinitionFinally
CONTRIBUTING.mdsaid the library support python>=3.6 however #548 introduced a requirement of python>=3.8. The supported python version has been updated to python>=3.8 (#571 aims to introduce support for python 3.11 so the statement should be true in the near future.)Currently Asogaard is referenced for the wandb team, maybe we should also update this? Since he is not currently working on the project anymore