Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/allow multi federation #4

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

eyn
Copy link

@eyn eyn commented Oct 31, 2019

This PR allows federation to work with multiple copies of postgraphile federated. The changes are quite extensive. See examples/ for multiple services federated together.

Would love some feedback on general approach.

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the pull request! I'm afraid I'm unlikely to have sufficient time to properly review this approach in the next few weeks. I looked through it a bit but as you say the changes are quite extensive and I've got a lot of catching up to do on various other things. Feel free to ping me again end of November and I'll see if I can allocate some time to properly reviewing it; in the mean time I encourage you to get feedback from other PostGraphile/Federation users.

kind: "Argument",
name: Name(argName),
value,
})),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's extract the args logic into a helper function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants