Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to use primary key as additional @key directive #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

phryneas
Copy link
Contributor

I tried another shot at what #2 was trying to accomplish, since I'm currently using a local build of this patched with #2 (which is working fine for me) and would love to get back to using an "official package".

Unfortunately, though, I'm a bit stuck on selectGraphQLResultFromTable - I would expect to be able to use it like in this PR, but it doesn't seem to be doing what I want - or the expected return value is not what I think it should be.

Could you please take a look at this and give me a hint on where I'm going wrong?

src/index.ts Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@benjie
Copy link
Member

benjie commented Oct 22, 2019

Hope this helps!

@phryneas
Copy link
Contributor Author

Definitely helps, thank you! I'm a bit swamped right now but I'll try to get around to this ASAP :)

@benjie
Copy link
Member

benjie commented Oct 28, 2019

@phryneas I went into selectGraphQLResultFromTable in more detail in another issue; you might find it useful: graphile/crystal#1168 (comment)

@phryneas
Copy link
Contributor Author

phryneas commented Nov 6, 2019

@benjie this seems to be working now - care to take a second look? :)

@benjie
Copy link
Member

benjie commented Nov 13, 2019

I'm afraid I'm unlikely to have sufficient time to properly review this in the next couple weeks. Feel free to ping me again end of November and I'll see if I can allocate some time to properly reviewing it; in the mean time I encourage you to get feedback from other PostGraphile/Federation users.

@vinverdy
Copy link

will this PR be merged? Kudos

@benjie
Copy link
Member

benjie commented Jun 24, 2020

@graphile/federation-team may merge it at will; I'm not involved in any APIs using Federation so don't have sufficient context to maintain this project.

@vinverdy
Copy link

ah i see, okay thanks for your reply

@wtgtybhertgeghgtwtg
Copy link

@graphile/federation-team no longer seems to exist. Is there any path forward for this PR?

@benjie
Copy link
Member

benjie commented Jan 5, 2021

If someone wants to sponsor me to look at federation again (or if one of the larger existing sponsors wants to throw their weight behind it) I'm happy to take a look, but I'm not aware of many people in the Graphile ecosystem using federation (and for good reason when we have things like makeExtendSchemaPlugin) so all the other tasks are currently taking priority over this for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants