Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support skipping optimizing chunks but not skipping post optimizing that chunk and some cleanup refactor #19

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+101 −85
Open

Support skipping optimizing chunks but not skipping post optimizing that chunk and some cleanup refactor #19

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b77c248
refactor to improve efficiency
kevintsq Jul 29, 2024
89e1b8f
fix bug
kevintsq Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix bug
@kevintsq
kevintsq committed Jul 29, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 89e1b8f364483933afe9fb477095a5adca2d4811
2 changes: 1 addition & 1 deletion scripts/full_train.py
View file
Original file line number Diff line number Diff line change
@@ -81,7 +81,7 @@ def setup_dirs(images, depths, masks, colmap, chunks, output, project):
print("Skipping coarse")
else:
if args.use_slurm:
if args.args.extra_training_args != "":
if args.extra_training_args != "":
print("\nThe script does not support passing extra_training_args to slurm!!\n")
submitted_jobs_ids = []
slurm_args = [