Move the category fragment to the category prop

graphcommerce-org · Jan 16, 2025 · 590f064 · 590f064
1 parent 87df248
commit 590f064
Show file tree

Hide file tree

Showing 8 changed files with 17 additions and 17 deletions.
diff --git a/.changeset/silly-tigers-scream.md b/.changeset/silly-tigers-scream.md
@@ -0,0 +1,5 @@
+---
+'@graphcommerce/magento-category': patch
+---
+
+Move the category fragment to the category prop
diff --git a/examples/magento-graphcms/components/ProductListLayout/ProductListLayoutClassic.tsx b/examples/magento-graphcms/components/ProductListLayout/ProductListLayoutClassic.tsx
@@ -47,7 +47,7 @@ export const ProductListLayoutClassic = memoDeep((props: ProductListLayoutProps)
           </LayoutTitle>
           <CategoryDescription
             sx={(theme) => ({ textAlign: 'center', mb: theme.spacings.sm })}
-            {...category}
+            category={category}
           />
           <CategoryChildren
             params={params}

diff --git a/examples/magento-graphcms/components/ProductListLayout/ProductListLayoutDefault.tsx b/examples/magento-graphcms/components/ProductListLayout/ProductListLayoutDefault.tsx
@@ -71,7 +71,7 @@ export const ProductListLayoutDefault = memoDeep((props: ProductListLayoutProps)
               textAlignMd='center'
               textAlignSm='center'
               sx={(theme) => ({ px: theme.page.horizontal })}
-              {...category}
+              category={category}
             />
             <CategoryChildren
               sx={(theme) => ({

diff --git a/examples/magento-graphcms/components/ProductListLayout/ProductListLayoutSidebar.tsx b/examples/magento-graphcms/components/ProductListLayout/ProductListLayoutSidebar.tsx
@@ -95,7 +95,7 @@ export const ProductListLayoutSidebar = memoDeep((props: ProductListLayoutProps)
             <>
               <Typography variant='h1'>{title}</Typography>
 
-              <CategoryDescription textAlignMd='start' textAlignSm='start' {...category} />
+              <CategoryDescription textAlignMd='start' textAlignSm='start' category={category} />
               <MediaQuery query={(theme) => theme.breakpoints.down('md')}>
                 <CategoryChildren params={params}>{category?.children}</CategoryChildren>
               </MediaQuery>

diff --git a/examples/magento-open-source/components/ProductListLayout/ProductListLayoutClassic.tsx b/examples/magento-open-source/components/ProductListLayout/ProductListLayoutClassic.tsx
@@ -47,7 +47,7 @@ export const ProductListLayoutClassic = memoDeep((props: ProductListLayoutProps)
           </LayoutTitle>
           <CategoryDescription
             sx={(theme) => ({ textAlign: 'center', mb: theme.spacings.sm })}
-            {...category}
+            category={category}
           />
           <CategoryChildren
             params={params}

diff --git a/examples/magento-open-source/components/ProductListLayout/ProductListLayoutDefault.tsx b/examples/magento-open-source/components/ProductListLayout/ProductListLayoutDefault.tsx
@@ -77,7 +77,7 @@ export const ProductListLayoutDefault = memoDeep((props: ProductListLayoutProps)
               textAlignMd='center'
               textAlignSm='center'
               sx={(theme) => ({ px: theme.page.horizontal })}
-              {...category}
+              category={category}
             />
             <CategoryChildren
               sx={(theme) => ({

diff --git a/examples/magento-open-source/components/ProductListLayout/ProductListLayoutSidebar.tsx b/examples/magento-open-source/components/ProductListLayout/ProductListLayoutSidebar.tsx
@@ -96,7 +96,7 @@ export const ProductListLayoutSidebar = memoDeep((props: ProductListLayoutProps)
             <>
               <Typography variant='h1'>{title}</Typography>
 
-              <CategoryDescription textAlignMd='start' textAlignSm='start' {...category} />
+              <CategoryDescription textAlignMd='start' textAlignSm='start' category={category} />
               <MediaQuery query={(theme) => theme.breakpoints.down('md')}>
                 <CategoryChildren params={params}>{category?.children}</CategoryChildren>
               </MediaQuery>

diff --git a/packages/magento-category/components/CategoryDescription/CategoryDescription.tsx b/packages/magento-category/components/CategoryDescription/CategoryDescription.tsx
@@ -14,19 +14,14 @@ const { withState } = extendableComponent<StateProps, typeof componentName, type
   parts,
 )
 
-export type CategoryDescriptionProps = Omit<CategoryDescriptionFragment, 'uid'> &
-  StateProps & { sx?: SxProps<Theme> }
+export type CategoryDescriptionProps = StateProps & {
+  sx?: SxProps<Theme>
+  category: Omit<CategoryDescriptionFragment, 'uid'>
+}
 
 export function CategoryDescription(props: CategoryDescriptionProps) {
-  const {
-    name,
-    description,
-    display_mode,
-    sx = [],
-    textAlignSm = 'center',
-    textAlignMd = 'center',
-    ...divProps
-  } = props
+  const { category, sx = [], textAlignSm = 'center', textAlignMd = 'center', ...divProps } = props
+  const { description } = category
 
   const classes = withState({ textAlignSm, textAlignMd })