This repository has been archived by the owner on Mar 20, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…taining features except for SlicedGraph
# Conflicts: # Graph/models.py # Graph/test.py # vgbrowser/settings.py
…ries in persistent memory. Tests still broken.
…taining features except for SlicedGraph
…ries in persistent memory. Tests still broken.
…ample_graph with factory_input.gfa file written by hand. build_from_test_slices() converted for quick test declarations. GraphTest shows GFA file and slices declaration are the same.
… backward_paths. Add Slice stub for the transition. Currently skipping DAGify tests.
@6br Once you have a chance to review this, it's ready to be merged into master. My continuing work has moved to another branch, so this is stable. |
Sure, I will review in this weekend. |
6br
approved these changes
Aug 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is transitioning all of our old code from a pure Python object to using Django Queries and our newer backend that matches #4 Backend Specification models.