-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A toy example for #8 based on install.R #9
base: main
Are you sure you want to change the base?
Conversation
@@ -0,0 +1 @@ | |||
install.packages("tidyverse") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would place this code above.
if [ -f install.R ] | ||
then | ||
echo "installing R packages..." | ||
Rscript install.R |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script could be an Rscript script (if you want to call cat(....)
etc). Moreover there is no gain in farming out to yet another script. Just do Rscript -e 'install.packages(c("whatever", "you", "put", "here"))'
.
My $0.02 but not my space. Still, this is a r2u codespace so I would tend to keep the R admin lean and simple to let r2u shine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually did not want the user to edit the stuff in .devcontainer
, thus the bifurcation into a wrapper script (always there, no need for the user to edit, no Linux knowledge necessary), and an optional "pure R" script in the (visible) main directory.
The additional pull request for #7 went to the same pull request as before. Sorry. |
No description provided.