Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 Nether Roof Renderer #24

Merged
merged 3 commits into from
Feb 8, 2024
Merged

V3 Nether Roof Renderer #24

merged 3 commits into from
Feb 8, 2024

Conversation

ydal251
Copy link
Contributor

@ydal251 ydal251 commented Feb 8, 2024

Requested by Folas1337 here: https://discord.com/channels/1166280318349758464/1166281855251779594/1204459574040465448

Simply copied the vanilla renderer and removed the world ceiling check so the render starts at sky limit.

Map Image:
image

ydal251 and others added 3 commits February 7, 2024 21:51
Copied vanilla renderer and removed world ceiling check so that render starts looking for blocks at build height
Copy link
Owner

@granny granny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point the duplicate code should be refactored into a helper class, LGTM otherwise.

@granny granny merged commit 979d5df into granny:v3 Feb 8, 2024
3 of 4 checks passed
U5B pushed a commit to U5B/Pl3xMap that referenced this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants