Apply suggestions from code review

granny · Mar 30, 2024 · ea47fc3 · ea47fc3
1 parent 27bd662
commit ea47fc3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/webmap/src/control/BlockInfoControl.ts b/webmap/src/control/BlockInfoControl.ts
@@ -44,11 +44,8 @@ export class BlockInfoControl extends ControlBox {
         const tileX: number = (x / step) & 511;
         const tileZ: number = (z / step) & 511;
 
-        const unknownBlock: string = this._pl3xmap.settings!.lang.blockInfo.unknown.block ?? 'Unknown block';
-        const unknownBiome: string = this._pl3xmap.settings!.lang.blockInfo.unknown.biome ?? 'Unknown biome';
-
-        let blockName: string = unknownBlock;
-        let biomeName: string = unknownBiome;
+        let blockName: string = this._pl3xmap.settings!.lang.blockInfo.unknown.block ?? 'Unknown block';
+        let biomeName: string = this._pl3xmap.settings!.lang.blockInfo.unknown.biome ?? 'Unknown biome';
         let y: number | undefined;
 
         const blockInfo: BlockInfo | undefined = this._pl3xmap.worldManager.currentWorld?.getBlockInfo(zoom, fileX, fileZ);

diff --git a/webmap/src/settings/Lang.ts b/webmap/src/settings/Lang.ts
@@ -85,7 +85,6 @@ export class Label {
 /**
  * Represents 'unknown' values for BlockInfo.
  */
-
 export class BlockInfoUnknown {
     private readonly _block: string;
     private readonly _biome: string;
@@ -109,7 +108,6 @@ export class BlockInfoUnknown {
 /**
  * Represents a label and a value, with 'unknown' values.
  */
-
 export class BlockInfo extends Label {
     private readonly _unknown: BlockInfoUnknown;