Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Test all KZG backends on all targets in CI #115

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

sauliusgrigaitis
Copy link
Member

No description provided.

@sauliusgrigaitis sauliusgrigaitis marked this pull request as draft February 17, 2025 10:42
@sauliusgrigaitis
Copy link
Member Author

@ArtiomTr the build started to fail when I merged #88. I suggest to try to make all backends passing on all platforms and then disable those that we can't make work.

@ArtiomTr
Copy link
Contributor

I think bls crate doesn't support both zkcrypto & blst at the same time - only one must be picked now. If we want to maximize checked backends, we can enable these:

include:
  - os: ubuntu-latest
    backend: arkworks,blst,constantine,mcl # no zkcrypto (because of blst)
  - os: windows-latest
    backend: arkworks,constantine,zkcrypto # no blst (because of zkcrypto) and mcl
  - os: macos-latest
    backend: arkworks,blst,mcl # no zkcrypto & constantine

So on rust-kzg side, mcl backend needs fixes for windows, and constantine for macos. To make blst & zkcrypto work at the same time, refactoring for bls crate is needed.

@shreyas-londhe
Copy link
Contributor

Hi @ArtiomTr! Currently the bls crate is written such that the backends can be enabled by mentioning the backend as a feature flag. It is by design that we cannot enable multiple backends simultaneously, which imo is the best practice to follow as we do not want any conflicts at runtime because of backend discrepancies.

Please let me know if you think there can be a better solution to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants