remove todo! macros in network

grandinetech · May 13, 2024 · 6bd6945 · 6bd6945
1 parent 570221b
commit 6bd6945
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 6 deletions.
diff --git a/eip_7594/src/lib.rs b/eip_7594/src/lib.rs
@@ -49,8 +49,8 @@ const BYTES_PER_CELL: usize = FIELD_ELEMENTS_PER_CELL * BYTES_PER_FIELD_ELEMENT;
 type BytesPerCell = U2048;
 const CELLS_PER_BLOB: usize = FIELD_ELEMENTS_PER_EXT_BLOB / FIELD_ELEMENTS_PER_CELL;
 const KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH: usize = 4;
-const MAX_BLOBS_PER_BLOCK: u64 = 6; //todo!();
-const MAX_BLOB_COMMITMENTS_PER_BLOCK: usize = 6; // todo!();
+const MAX_BLOBS_PER_BLOCK: u64 = 6;
+const MAX_BLOB_COMMITMENTS_PER_BLOCK: usize = 6;
 
 type PolynomialCoeff = [Bytes32; FIELD_ELEMENTS_PER_EXT_BLOB];
 type CellID = u64;

diff --git a/p2p/src/block_sync_service.rs b/p2p/src/block_sync_service.rs
@@ -359,8 +359,8 @@ impl<P: Preset> BlockSyncService<P> {
                             self.sync_manager.block_by_root_request_finished(block_root);
                             self.request_blobs_and_blocks_if_ready()?;
                         }
+                        //TODO(feature/eip7549)
                         P2pToSync::DataColumnsByRangeRequestFinished(request_id) => {
-                            todo!()
                             // self.sync_manager.blobs_by_range_request_finished(request_id);
                             // self.request_blobs_and_blocks_if_ready()?;
                         }

diff --git a/p2p/src/network.rs b/p2p/src/network.rs
@@ -1159,7 +1159,13 @@ impl<P: Preset> Network<P> {
         peer_request_id: PeerRequestId,
         request: DataColumnsByRootRequest,
     ) {
-        todo!();
+        // TODO(feature/eip7549): implement this
+        self.log(
+            Level::Debug,
+            format_args!(
+                "received DataColumnsByRoot request (peer_id: {peer_id}, request: {request:?})"
+            ),
+        );
     }
 
     fn handle_data_columns_by_range_request(
@@ -1168,7 +1174,15 @@ impl<P: Preset> Network<P> {
         peer_request_id: PeerRequestId,
         request: DataColumnsByRangeRequest,
     ) -> Result<()> {
-        todo!();
+        // TODO(feature/eip7549): implement this
+        self.log(
+            Level::Debug,
+            format_args!(
+                "received DataColumnsByRange request (peer_id: {peer_id}, request: {request:?})"
+            ),
+        );
+
+        Ok(())
     }
 
     fn handle_blobs_by_root_request(
@@ -1478,7 +1492,7 @@ impl<P: Preset> Network<P> {
                 );
             }
             // TODO(feature/eip7594)
-            Response::DataColumnsByRange(Some(data_column_sidecar)) => todo!(),
+            Response::DataColumnsByRange(Some(data_column_sidecar)) => {}
             Response::DataColumnsByRange(None) => {
                 self.log_with_feature(format_args!(
                     "peer {peer_id} terminated DataColumnsByRange response stream for request_id: {request_id}",