This repository was archived by the owner on May 26, 2022. It is now read-only.
Docker compose improvements #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR worked for me (Ubuntu 18.04, Docker version 18.09.6, docker-compose version 1.24.1) |
|
Thanks, @alainlep! This looks good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I fixed the missing classnames dependencies
Made the docker-compose use environment variables of docker-compose.yml file instead of the .env configuration
The .env configuration can still be used when launched locally
Added a proxy for react ui that can use environment variable in order to work locally and with docker-compose without modification to the default configuration.
This pull request may resolve issues #26 #29 #31
Nice project, I hope this can help.