Add websocket header support to the ROS-client #124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some device that I am using has a websocket available that is protected with a token. This token needs to be passed via the websocket connection header. This PR adds websocket header support to the ROS-client.
The headers can be added to the ROS-client like this, also see
test_ws_headers.py
:What type of change is this?
I don't see a reason why this couldn't be backwards compatible, but I could be wrong.
Checklist
CHANGELOG.rst
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke check
).Questions
RosBridgeClientFactory
.