-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dovetail Tenon-Mortise Joint #309
Merged
papachap
merged 38 commits into
gramaziokohler:main
from
papachap:dovetail_tenon_mortise
Oct 30, 2024
Merged
Dovetail Tenon-Mortise Joint #309
papachap
merged 38 commits into
gramaziokohler:main
from
papachap:dovetail_tenon_mortise
Oct 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as_timber into dovetail_joint
…as_timber into internal_forces_solver
…compas_timber into dovetail_tenon_mortise
…compas_timber into dovetail_tenon_mortise
…into dovetail_tenon_mortise
…hler/compas_timber into dovetail_tenon_mortise
…compas_timber into dovetail_tenon_mortise
…into dovetail_tenon_mortise
chenkasirer
reviewed
Oct 30, 2024
chenkasirer
reviewed
Oct 30, 2024
chenkasirer
reviewed
Oct 30, 2024
chenkasirer
reviewed
Oct 30, 2024
chenkasirer
reviewed
Oct 30, 2024
@papachap left some minor comments but otherwise lgtm. |
…into dovetail_tenon_mortise
chenkasirer
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR concerns the implementation of the DovetailTenon/DovetailMortise BTLx Processes as well as the creation of the TDovetailJoint.
What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas_timber.datastructures.Beam
.