Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix_incorrect_import #302

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Fix_incorrect_import #302

merged 2 commits into from
Oct 23, 2024

Conversation

obucklin
Copy link
Contributor

@obucklin obucklin commented Oct 22, 2024

The compas.geometry version of intersection_line_plane() does not return the parameter on the line, which is needed to know which end of the beam an extension is on. This made the application of extensions fail. the compas_timber version has the parameter. reverted the import to the CT version of the method.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas_timber.datastructures.Beam.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Copy link
Contributor

@chenkasirer chenkasirer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@chenkasirer
Copy link
Contributor

chenkasirer commented Oct 23, 2024

@obucklin thanks for fixing this rather elusive issue. To make this less likely to happen in the future, I created #303 and added a couple of unittests.

@obucklin
Copy link
Contributor Author

@obucklin thanks for fixing this rather elusive issue. To make this less likely to happen in the future, I created #303 and added a couple of unittests.

@chenkasirer so should I merge or close PR?

@chenkasirer
Copy link
Contributor

@obucklin merge please!

@jonashaldemann jonashaldemann merged commit e67ec2e into main Oct 23, 2024
14 checks passed
@obucklin obucklin deleted the fix_incorrect_import branch October 23, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants