-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gh bake rework #290
Gh bake rework #290
Conversation
@@ -78,7 +78,31 @@ def create_box_map(pln, sx, sy, sz): | |||
dx = Interval(-sx * 0.5, sx * 0.5) | |||
dy = Interval(-sy * 0.5, sy * 0.5) | |||
dz = Interval(-sz * 0.5, sz * 0.5) | |||
if swap_uv: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so is it ok that there's only one swap_uv
? this will flip the coordinates for both beams and plates right? can it be user might want to flip for just one of them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've set swap_uv of the Beams to False, because we usually don't need it (yet):
self.add_brep_to_document(beam_breps, beam_frames, beam_layer_name, b_dimx, b_dimy, b_dimz, False)
But is there a clever way to avoid this unnecessary setting in this case without duplicating too many lines to solve Beams & Plates?
@jonashaldemann looks generally good, although I did leave a few comments. Now I'm not strictly against this re-work but keep in mind that as the selection of different element types grows, the number of input fields of this component is going to grow. This might end up being not very nice. But not sure having multiple components is the best solution either. Just something to keep in mind. |
Ok @chenkasirer, I see your objection. Maybe we can discuss it next week so I can estimate how many types there might be. Possibly the way is to create separate "Bakeries" but add the Layer Name Input to help assigning the Parts to Rhino Layers. |
Merged both Baking Components into one that bakes Beams & Plates. The Rhino Layers on which the elements should be baked can now also be defined.
What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas_timber.datastructures.Beam
.