Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readme #256

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Fix readme #256

merged 1 commit into from
Jul 2, 2024

Conversation

gonzalocasas
Copy link
Member

@gonzalocasas gonzalocasas commented Jun 23, 2024

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas_timber.datastructures.Beam.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@gonzalocasas gonzalocasas added the no changelog No changes to CHANGELOG.md required in this PR label Jun 23, 2024
@gonzalocasas
Copy link
Member Author

well.. not exactly needing a PR :P

Copy link
Contributor

@obucklin obucklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@chenkasirer chenkasirer merged commit 523d99d into main Jul 2, 2024
14 of 15 checks passed
@chenkasirer chenkasirer deleted the gonzalocasas-patch-1 branch July 2, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog No changes to CHANGELOG.md required in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants