Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lbutt extend cross #213

Merged
merged 29 commits into from
Feb 15, 2024
Merged

Lbutt extend cross #213

merged 29 commits into from
Feb 15, 2024

Conversation

chenkasirer
Copy link
Contributor

@chenkasirer chenkasirer commented Feb 7, 2024

  • Merged the functionality of DecomposeBeam and ShowBeamFrame and removed the latter.
  • Added visualization for beams faces and their normals to DecomposeBeam.
  • Added two flags that can be used when assigning L-butt joints in a multi-beam joint situation:
    • modify_cross when set to False (default True) tells CT no to modify the cross beam (which might already be joined)
    • reject_i when set to True (default False) BeamJoiningError is raised when the main and cross meet in an I topology. I is generally allowed with L-butt but might not be desired when the cross is already joined at the same end.

When both are left as default, the L-butt behavior is as before.

image

image

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas_timber.datastructures.Beam.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

assert self.main_beam and self.cross_beam

index, cfr = self.get_face_most_ortho_to_beam(self.main_beam, self.cross_beam, ignore_ends=False)
if index in [5, 6]: # end faces
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my concern is, what happens if someone wants to make a butt joint with beam incidence angle of < 45deg? In this case, the joint will have one of the ends as cfr or index will be 5 or 6, even though the user wants to join in the old way with just the 4 main faces.

Should we add this as a kwarg in the GH component? it could be a cutoff angle with default of 45.

Copy link
Contributor Author

@chenkasirer chenkasirer Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a sketch here would help.

but if I get it right though, what you're suggesting sounds like an l-miter, no?
otherwise, when considering only the 4 main faces like before this rework you would get something like this:
image

Basically L-Miter is the only joint we currently have that supports an I topology (knows how to handle end to end joining)

image

@chenkasirer chenkasirer mentioned this pull request Feb 14, 2024
7 tasks
@chenkasirer chenkasirer merged commit 11d1afd into main Feb 15, 2024
11 checks passed
@chenkasirer chenkasirer deleted the lbutt_extend_cross branch February 15, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants