-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lbutt extend cross #213
Lbutt extend cross #213
Conversation
assert self.main_beam and self.cross_beam | ||
|
||
index, cfr = self.get_face_most_ortho_to_beam(self.main_beam, self.cross_beam, ignore_ends=False) | ||
if index in [5, 6]: # end faces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my concern is, what happens if someone wants to make a butt joint with beam incidence angle of < 45deg? In this case, the joint will have one of the ends as cfr
or index
will be 5 or 6, even though the user wants to join in the old way with just the 4 main faces.
Should we add this as a kwarg in the GH component? it could be a cutoff angle with default of 45.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a sketch here would help.
but if I get it right though, what you're suggesting sounds like an l-miter, no?
otherwise, when considering only the 4 main faces like before this rework you would get something like this:
Basically L-Miter is the only joint we currently have that supports an I
topology (knows how to handle end to end joining)
DecomposeBeam
andShowBeamFrame
and removed the latter.DecomposeBeam
.modify_cross
when set toFalse
(defaultTrue
) tells CT no to modify the cross beam (which might already be joined)reject_i
when set toTrue
(defaultFalse
)BeamJoiningError
is raised when the main and cross meet in an I topology. I is generally allowed with L-butt but might not be desired when the cross is already joined at the same end.When both are left as default, the L-butt behavior is as before.
What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas_timber.datastructures.Beam
.