Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T/L-butt extensions #206

Merged
merged 3 commits into from
Feb 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed

* `BeamFromCurve` GH component accepts now referenced Rhino curves, referenced Rhino object IDs and internalized lines.
* Fixed `FeatureError` when L-Butt applies the cutting plane.
* Fixed T-Butt doesn't get extended to cross beam's plane.

### Removed

Expand Down
Binary file modified examples/Grasshopper/CT_NEW_UI_Example.3dm
Binary file not shown.
Binary file modified examples/Grasshopper/CT_NEW_UI_Example.gh
Binary file not shown.
7 changes: 5 additions & 2 deletions src/compas_timber/connections/l_butt.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,13 @@ def add_features(self):
except Exception as ex:
raise BeamJoinningError(beams=self.beams, joint=self, debug_info=str(ex))

extension_tolerance = 0.01 # TODO: this should be proportional to the unit used
start_main, end_main = self.main_beam.extension_to_plane(main_cutting_plane)
start_cross, end_cross = self.cross_beam.extension_to_plane(cross_cutting_plane)
self.main_beam.add_blank_extension(start_main, end_main, self.key)
self.cross_beam.add_blank_extension(start_cross, end_cross, self.key)
self.main_beam.add_blank_extension(start_main + extension_tolerance, end_main + extension_tolerance, self.key)
self.cross_beam.add_blank_extension(
start_cross + extension_tolerance, end_cross + extension_tolerance, self.key
)

f_main = CutFeature(main_cutting_plane)
self.main_beam.add_features(f_main)
Expand Down
5 changes: 5 additions & 0 deletions src/compas_timber/connections/t_butt.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,16 @@ def add_features(self):

if self.features:
self.main_beam.remove_features(self.features)

try:
cutting_plane = self.get_cutting_plane()
except Exception as ex:
raise BeamJoinningError(beams=self.beams, joint=self, debug_info=str(ex))

extension_tolerance = 0.01 # TODO: this should be proportional to the unit used
start_main, end_main = self.main_beam.extension_to_plane(cutting_plane)
self.main_beam.add_blank_extension(start_main + extension_tolerance, end_main + extension_tolerance, self.key)

trim_feature = CutFeature(cutting_plane)
self.main_beam.add_features(trim_feature)
self.features = [trim_feature]
Loading