-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implemented half lap joint #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, Jonas!
- i've implemented a more proper solution to this brep from mesh hack, once it's ready to use we can change it together.
- run
invoke format
and it'll automatically re-format your code - run
invoke lint
, it'll then tell where exactly there are linting/formatting issues which you will have to fix manually. - See other comments below.
src/compas_timber/ghpython/components/CT_JointDef_Half_Lap/metadata.json
Outdated
Show resolved
Hide resolved
src/compas_timber/ghpython/components/CT_JointDef_Half_Lap/metadata.json
Outdated
Show resolved
Hide resolved
src/compas_timber/ghpython/components/CT_JointDef_Half_Lap/metadata.json
Outdated
Show resolved
Hide resolved
@jonashaldemann fix is merged so if you merge |
…/compas_timber into feature/lap_joint
…/compas_timber into feature/lap_joint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. left a couple of comments, please have a look before merging.
|
||
class XHalfLapDefinition(component): | ||
def RunScript(self, MainBeam, CrossBeam): | ||
max_distance_from_beams = max([MainBeam[0].width, MainBeam[0].height, CrossBeam[0].width, CrossBeam[0].height]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest moving this line to below all the input validity checks below. Otherwise it might try to calculate the distance even when there's no valid input.
src/compas_timber/ghpython/components/CT_JointDef_XHalfLap/code.py
Outdated
Show resolved
Hide resolved
…e.py Co-authored-by: Chen Kasirer <[email protected]>
Co-authored-by: Chen Kasirer <[email protected]>
completed requested changes
Implemented a new joint type: Half-lap joint.
What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas_timber.datastructures.Beam
.