Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented half lap joint #118

Merged
merged 19 commits into from
Sep 18, 2023
Merged

implemented half lap joint #118

merged 19 commits into from
Sep 18, 2023

Conversation

jonashaldemann
Copy link
Contributor

@jonashaldemann jonashaldemann commented Jul 26, 2023

Implemented a new joint type: Half-lap joint.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas_timber.datastructures.Beam.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Copy link
Contributor

@chenkasirer chenkasirer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, Jonas!

  1. i've implemented a more proper solution to this brep from mesh hack, once it's ready to use we can change it together.
  2. run invoke format and it'll automatically re-format your code
  3. run invoke lint, it'll then tell where exactly there are linting/formatting issues which you will have to fix manually.
  4. See other comments below.

src/compas_timber/connections/half_lap.py Outdated Show resolved Hide resolved
src/compas_timber/connections/half_lap.py Outdated Show resolved Hide resolved
src/compas_timber/connections/half_lap.py Outdated Show resolved Hide resolved
src/compas_timber/connections/half_lap.py Outdated Show resolved Hide resolved
src/compas_timber/connections/half_lap.py Outdated Show resolved Hide resolved
src/compas_timber/connections/half_lap.py Outdated Show resolved Hide resolved
src/compas_timber/connections/half_lap.py Outdated Show resolved Hide resolved
src/compas_timber/connections/half_lap.py Outdated Show resolved Hide resolved
src/compas_timber/connections/half_lap.py Outdated Show resolved Hide resolved
src/compas_timber/connections/half_lap.py Outdated Show resolved Hide resolved
src/compas_timber/connections/half_lap.py Outdated Show resolved Hide resolved
src/compas_timber/connections/half_lap.py Outdated Show resolved Hide resolved
src/compas_timber/connections/half_lap.py Outdated Show resolved Hide resolved
src/compas_timber/connections/half_lap.py Outdated Show resolved Hide resolved
src/compas_timber/connections/__init__.py Outdated Show resolved Hide resolved
@chenkasirer
Copy link
Contributor

@jonashaldemann fix is merged so if you merge main onto your feature branch you should be able to use the latest COMPAS core commit.

Copy link
Contributor

@chenkasirer chenkasirer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. left a couple of comments, please have a look before merging.


class XHalfLapDefinition(component):
def RunScript(self, MainBeam, CrossBeam):
max_distance_from_beams = max([MainBeam[0].width, MainBeam[0].height, CrossBeam[0].width, CrossBeam[0].height])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest moving this line to below all the input validity checks below. Otherwise it might try to calculate the distance even when there's no valid input.

src/compas_timber/connections/x_halflap.py Outdated Show resolved Hide resolved
@chenkasirer chenkasirer dismissed funkchaser’s stale review September 18, 2023 12:00

completed requested changes

@jonashaldemann jonashaldemann merged commit 70f493e into main Sep 18, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants