Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
  • Loading branch information
chenkasirer committed Jan 31, 2024
2 parents 5036ea8 + cb615bb commit 49e237e
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
11 changes: 6 additions & 5 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,21 +22,22 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* Added new component `ShowFeatureErrors`.
* Added new component `ShowJoiningErrors`.
* Added `FeatureApplicator` classes which report errors during feature application.
* added `L-HalfLapJoint`
* added `T-HalfLapJoint`
* added `ShowTopologyTypes` GH Component
* Added `L-HalfLapJoint`.
* Added `T-HalfLapJoint`.
* Added `ShowTopologyTypes` GH Component.

### Changed

* Feature application now fails more gracefully (un-processed geometry is returned).
* Attempting to join beams which are already joined raises `BeamJoiningError` instead of `AssemblyError`
* `Joint.add_features` which fails to calculate anything raises `BeamJoiningError`.
* Changed COMPAS dependency to `compas==2.0.0beta.4`.
* Assembly component shows blanks when `CeateGeometry` flag is set to `False`.

### Removed

* removed `JointDef` GH components
* removed `AutomaticJoint` GH Component. Joint rules are now input directly into `TimberAssembly`
* Removed `JointDef` GH components.
* Removed `AutomaticJoint` GH Component. Joint rules are now input directly into `TimberAssembly`.

## [0.4.0] 2024-01-24

Expand Down
Binary file modified examples/Grasshopper/CT_NEW_UI_Example.gh
Binary file not shown.
3 changes: 3 additions & 0 deletions src/compas_timber/ghpython/components/CT_Assembly/code.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,9 @@ def RunScript(self, Beams, JointRules, Features, MaxDistance, CreateGeometry):
scene.add(result.geometry)
if result.debug_info:
debug_info.add_feature_error(result.debug_info)
else:
for beam in Assembly.beams:
scene.add(beam.blank)

if debug_info.has_errors:
self.AddRuntimeMessage(Warning, "Error found during joint creation. See DebugInfo output for details.")
Expand Down

0 comments on commit 49e237e

Please sign in to comment.