-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates #1
Updates #1
Conversation
I think this covers all the pending topics except the "Session controller being too sticky", which I'm not entirely sure how to reproduce. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
lot's of formatting changes - was the linter/formatter on aixd setup differently?
@@ -50,15 +49,31 @@ def read(*names, **kwargs): | |||
], | |||
keywords=[], | |||
project_urls={}, | |||
packages=["aixd_grasshopper"], | |||
packages=["aixd_grasshopper", "compas_aixd"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is "compas_aixd"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is related to our need to hook up on the python -m compas_rhino.install
step, the way we hook up to it is by declaring a few small plugins in our code. A plugin is just a function that can be automatically detected by compas to serve some function, there are different types but two of these types that we need are: 1) a plugin that will do declare which packages to make available inside rhino, and 2) what happens after install and uninstall (in our case, we install and uninstall the GH components respectively).
However, in order to detect plugins, compas has the requirement that the package name is prefixed with compas_
. So, compas_aixd
is basically an almost empty package that only contains the "pointers" to where the plugins mentioned before are located in aixd_grasshopper
. You can identify the plugins because they are marked with a decorator (@compas.plugins.plugin
).
I was also a bit confused about why so many files didn't have formatting, I didn't dig much into it, but perhaps the GH branch was created before we enabled |
What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas.datastructures.Mesh
.