POC to use AbortSignal to cancel an ongoing download #296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently gramjs doesn't provide any way to cancel/abort an ongoing download.
I implemented a simple system which uses AbortController and AbortSignal to break the loop which fetches the chunks.
This is a POC so that we can discuss if there are any caveats in this idea. This can be simillary implemented for all other kinds of downloads (document, video, profile picture, etc).
Example:
This raises an
USER_ABORTED
error from downloadMedia which can be handled by the client.Note: This implementation is only checked with Nodejs, I haven't tested it in browsers.