feat: Add getAll, setAll, removeAll to List.Associative
#2224
+241
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
ospencer,
phated,
peblair,
marcusroberts,
jozanza and
alex-snezhko
as code owners
| } | ||
| } | ||
| /** | ||
| * Creates a new list with all values in the list of key-value pairs that match the key replaced. |
There was a problem hiding this comment.
Not really sure how I feel about the setAll function tbh, not sure when you would want this
There was a problem hiding this comment.
Me neither but I wanted the api's to match and I didn't see any harm in having it.
|
@spotandjake Can you rebase this? |
spotandjake
force-pushed
the
spotandjake-associative-all-query
branch
from
4b36f94 to
c01de06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
getAll,setAllandremoveAlltoList.Associative