feat(stdlib): Reimplement Number.gamma and Number.factorial
#2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
ospencer,
phated,
peblair,
marcusroberts,
jozanza and
alex-snezhko
as code owners
|
Looks like the tests are failing. |
We need to wait for #2181 to be merged. |
tests on this are now passing and its ready for review |
ospencer
reviewed
Oct 30, 2024
Co-authored-by: Oscar Spencer <[email protected]>
ospencer
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr re-implements
Number.gammaandNumber.factorial.This pr is blocked on #2181 as the tests will fail due to the precision issue when computing
sin(pi * z) / gamma(1 - z)I think we should also open an issue to port the c version here in the future as this approximation provides decent accuracy but we accumulate some extra error due to the error in other approximation functions such as
sin, this should also make things a little faster.This pr closes: #1478