Skip to content

chore: Pin CI dependencies #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

chore: Pin CI dependencies #201

wants to merge 13 commits into from

Conversation

ospencer
Copy link
Member

No description provided.

@ospencer ospencer requested a review from phated February 16, 2025 22:44
@ospencer ospencer self-assigned this Feb 16, 2025
@spotandjake
Copy link
Member

spotandjake commented Mar 20, 2025

The 4.12.1 windows build is failing because v3 only back-ported support to 4.13 see here.

still looking into why the others are failing with the libbinaryen symbol.

@spotandjake
Copy link
Member

spotandjake commented Mar 20, 2025

https://github.com/spotandjake/binaryen.ml/actions/runs/13976642425/job/39131977243

I got opam working on windows with some caveats:

  • I think we need to drop support for 4.12.1 as it is not supported by ocaml/setup-ocaml@v3
  • I was able to get the build working using the pr here with msys2 support
    • This doesn't handle caching though so builds take a bit longer
    • not upstreamed into ocaml/setup-ocaml yet

I'm going to keep playing around though as i don't feel like this is ideal.

@ospencer
Copy link
Member Author

Yeah, we'll drop support for 4.12.1. This totally should work with cygwin, so it'd be great if we figured that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants