-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I18nAutoConfiguration #13847
base: 7.0.x
Are you sure you want to change the base?
I18nAutoConfiguration #13847
Conversation
This branch currently fails in void "Test that switching language results in correct encodings"() {
when:"the show page is rendered in german"
go "/book/show/1?lang=de"
println driver.pageSource
then:"The language is correct"
$('a', class:'create').text() == 'Book anlegen'
$('input', class:'delete').@value == 'Löschen'
} BookFunctionalSpec > Test that switching language results in correct encodings FAILED
Condition not satisfied:
$('a', class:'create').text() == 'Book anlegen'
| | |
| | false
| | 11 differences (8% similarity)
| | (New-) (Book---)
| | (Book) (anlegen)
| New Book
[[[RemoteWebDriver: chrome on linux (aa76a1c57b7adbe2700eb5afe06537b6)] -> css selector: a.create]]
at functionaltests.BookFunctionalSpec.Test that switching language results in correct encodings(BookFunctionalSpec.groovy:31) |
@matrei Looks like it was because of this: Lines 117 to 119 in 2a0b7d2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to my tests, Grails 7 built from this branch currently passes grails-functional-tests.
Resolves
Continuing the process, but going about it slowly not to break anything...