-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add batchwrite functionality #144
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch on updating the typings!
You're missing the key updates in Tests.ts
and README
with how to utilize this feature, please update these as well. Thanks for the awesome work so far!
I need to test these via clasp upload before I can accept. I plan to do this in the coming days. |
Any updates? |
@LaughDonor Did you get around to testing it? :) |
The readme is updated, only writing tests remain. |
hey folks, are we planning to promote this to the library soon? |
@abkarino @grahamearley Will this be merged at some point? |
I am afraid, it is not really in my hand. At the moment, it only needs the tests to be written and the project maintainers to test it, verify it and merge it. I am already using it in my repo with some work projects. |
Hi @LaughDonor, @abkarino great work, could you request a re-review? |
I am really looking forward for this update to be merged - I have hundreds of sheets to import into Firestore, and each sheet is going to take at least 30 minutes or 1 hour to be fully imported. I reckon adding this feature would definitely reduce the time spent running the script. |
Resolves #65 , resolves #54
This allows batchwrites which has a solution for URL limit since the mask is put in the body.
I did forget to remove one line in the
package.json
file that changed the repo param and will need to be reverted back before merging.Checklist for your code
git clone
)?package.json
with a barenpm install
.npm install --global @google/clasp
clasp login
.clasp.json
file:Tests.ts
file which validates your change. GSUnit Reference (this one is missing)_
" to the function name.npm run lint
.npm run fix
.