Fix memory leak #1431
Merged
Fix memory leak #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The context needs to be closed when the connection is closed. We're using the context to ensure that this happens. The reason we need to close the context is so that the BaseEventEmitter is correctly shutdown when the connection is closed. This is being added here incase the context coming into NewConnection cannot be cancelled.
This will help cleanup the connection, as well as the eventLoop in initEvents.
ankur22
force-pushed
the
fix/memory-leak
branch
from
1243f06
to
2c88fcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a memory leak that was introduced (regression) when working on #1420. This is done by:
connectionthat will be closed whenclose()is called, which will ensure that theBaseEventEmitteris properly shutdown.browserthat will ensure that theconnectionand eventLoop are shutdown whenbrowser.Close()is called.Why?
This helps avoid memory leaks. The leaks were in the
BaseEventEmittersince theconnectionwas created with a background context. The background context wasn't being closed, and therefore goroutines and incoming messages from the connection were being held on the heap and not being cleared.Before the fix you can see the memory slowly increasing:
After the fix:
Checklist
Related PR(s)/Issue(s)