gateway: make tempo-query forwarding on gateway optional #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frzifus
force-pushed
the
allow_gateway_without_jaeger_ui
branch
from
1aaeba2 to
b13b0ee
Compare
frzifus
changed the title
pavolloffay
reviewed
Dec 4, 2023
| @@ -410,6 +518,11 @@ func TestTLSParameters(t *testing.T) { | |||
| }, | |||
| }, | |||
| Template: v1alpha1.TempoTemplateSpec{ | |||
| QueryFrontend: v1alpha1.TempoQueryFrontendSpec{ | |||
There was a problem hiding this comment.
To not break the test. Previously the trace.read.endpoint was configured even when tempo-query was disabled.
The alternative would be to remove:
assert.Contains(t, args, fmt.Sprintf("--traces.read.endpoint=https://%s:16686",
naming.ServiceFqdn(tempo.Namespace, tempo.Name, manifestutils.QueryFrontendComponentName)))
frzifus
force-pushed
the
allow_gateway_without_jaeger_ui
branch
3 times, most recently
from
35b13ac to
625b194
Compare
pavolloffay
reviewed
Dec 20, 2023
frzifus
force-pushed
the
allow_gateway_without_jaeger_ui
branch
from
625b194 to
5d60c07
Compare
pavolloffay
reviewed
Dec 21, 2023
Signed-off-by: Benedikt Bongartz <[email protected]>
Signed-off-by: Benedikt Bongartz <[email protected]>
Signed-off-by: Benedikt Bongartz <[email protected]>
frzifus
force-pushed
the
allow_gateway_without_jaeger_ui
branch
from
5d60c07 to
1708c1b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #705 +/- ##
=========================================
+ Coverage 0 77.66% +77.66%
=========================================
Files 0 68 +68
Lines 0 5157 +5157
=========================================
+ Hits 0 4005 +4005
- Misses 0 954 +954
- Partials 0 198 +198
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Benedikt Bongartz <[email protected]>
Signed-off-by: Benedikt Bongartz <[email protected]>
pavolloffay
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #628