fix: revive stack trace range chunking #3825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korniltsev
approved these changes
Jan 8, 2025
|
I'm cancelling it for now as we can confirm this is helpful. The issue mentioned in the PR description has a different nature and origin, and reviving stack trace chunking is not the best way to tackle it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3817.
The PR reverts #3583 as it causes a performance regression in compactors (issue #3817) in certain cases. You can find more details in our slack channel (thread).
The change affects only ingesters and is fully backward-compatible. I'm hesitant to make this configurable because it's very easy to misinterpret and misconfigure the parameter.