Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

godeltaprof: change gzip library #78

Merged
merged 3 commits into from
Nov 30, 2023
Merged

godeltaprof: change gzip library #78

merged 3 commits into from
Nov 30, 2023

Conversation

korniltsev
Copy link
Collaborator 

goos: linux
goarch: amd64
pkg: github.com/grafana/pyroscope-go/godeltaprof/compat
cpu: AMD Ryzen 9 5950X 16-Core Processor            
                                       │ ../../old.txt │            ../../new.txt            │
                                       │    sec/op     │    sec/op     vs base               │
HeapCompression-32                         2.201m ± 4%   1.672m ±  6%  -24.03% (p=0.002 n=6)
MutexCompression/ScalerMutexProfile-32     2.082m ± 4%   1.545m ±  6%  -25.83% (p=0.002 n=6)
MutexCompression/ScalerBlockProfile-32     2.151m ± 6%   1.529m ±  6%  -28.96% (p=0.002 n=6)
HeapRejectOrder-32                         657.1µ ± 7%   454.9µ ± 10%  -30.77% (p=0.002 n=6)
MutexRejectOrder/ScalerMutexProfile-32     624.5µ ± 6%   437.8µ ±  8%  -29.90% (p=0.002 n=6)
MutexRejectOrder/ScalerBlockProfile-32     574.7µ ± 7%   419.5µ ± 17%  -27.01% (p=0.002 n=6)
geomean                                    1.151m        831.2µ        -27.79%

@korniltsev korniltsev mentioned this pull request Nov 30, 2023
Closed
@korniltsev
Copy link
Collaborator Author

need to merge #79 before, to run tests on 1.16

@korniltsev korniltsev force-pushed the godeltaprof-klaupost-gzip-compression branch from 70e4233 to 62a3526 Compare November 30, 2023 07:03
kolesnikovae
kolesnikovae approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@korniltsev korniltsev merged commit 624dfcb into main Nov 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolesnikovae kolesnikovae kolesnikovae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korniltsev @kolesnikovae