Use CacheKeyGenerator implementation in error caching middleware #9644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use an implementation of the CacheKeyGenerator interface instead of bare function to generate cache keys for error caching. This allows downstream consumers (GEM) to inject custom logic for caching based on LBAC rules. Signed-off-by: Nick Pillitteri <[email protected]>
56quarters
force-pushed
the
56quarters/error-cache-key
branch
from
4367e59
to
6d84f3c
Compare
chencs
reviewed
Oct 17, 2024
56quarters
commented
Oct 17, 2024
| @@ -85,7 +86,7 @@ func (e *errorCachingHandler) Do(ctx context.Context, request MetricsQueryReques | |||
| } | |||
|
|
|||
| e.cacheLoadAttempted.Inc() | |||
| key := errorCachingKey(tenant.JoinTenantIDs(tenantIDs), request) | |||
| key := e.keyGen.QueryRequestError(ctx, tenant.JoinTenantIDs(tenantIDs), request) | |||
| hashedKey := cacheHashKey(key) | |||
|
|
|||
| if cachedErr := e.loadErrorFromCache(ctx, key, hashedKey, spanLog); cachedErr != nil { | |||
There was a problem hiding this comment.
This method uses the hashedKey to fetch the value from cache and then compares the stored key to generated one.
chencs
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Use an implementation of the CacheKeyGenerator interface instead of bare function to generate cache keys for error caching. This allows downstream consumers (GEM) to inject custom logic for caching based on LBAC rules.
Which issue(s) this PR fixes or relates to
Related #9028
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.