Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboards] Unify ingester autoscaling panels on writes dashboard #9617

Merged
merged 7 commits into from
Oct 15, 2024

Conversation

pr00se
Copy link
Contributor

@pr00se pr00se commented Oct 15, 2024

What this PR does

Use a single set of panels on the "Mimir / Writes" dashboard for ingest-storage and standard ingester autoscaling.

Regular autoscaling:
Screenshot 2024-10-15 at 2 00 19 AM

Ingest storage:
Screenshot 2024-10-15 at 2 00 48 AM

Which issue(s) this PR fixes or relates to

Fixes #N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@pr00se pr00se requested a review from a team as a code owner October 15, 2024 06:01
@pr00se pr00se changed the title [jsonnet] Ing autoscale panels [jsonnet] Unify ingester autoscaling panels on writes dashboard Oct 15, 2024
@pr00se pr00se changed the title [jsonnet] Unify ingester autoscaling panels on writes dashboard [dashboards] Unify ingester autoscaling panels on writes dashboard Oct 15, 2024
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

operations/mimir-mixin/dashboards/writes.libsonnet Outdated Show resolved Hide resolved
$.autoScalingActualReplicas('ingester') + { title: 'Replicas (leader zone)' } +
local replicaTemplateQueries = [
|||
max by (name) (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] Why by (name) given we don't display the {{ name }} in the legend?

Same comment applies below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed in d3f4726

operations/mimir-mixin/dashboards/writes.libsonnet Outdated Show resolved Hide resolved
@pr00se pr00se merged commit 197314a into main Oct 15, 2024
29 checks passed
@pr00se pr00se deleted the ing-autoscale-panels branch October 15, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants