helm: Fix typo in 5.5.0 changelog #9611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Varankin <[email protected]>
ortuman
approved these changes
Oct 14, 2024
|
Hey @narqo I think there are a few other typos in the changelog (memcached is in version 1.6.31 and not 1.6.28 and more importantly, it's not mentionned at all that Mimir was upgraded to 2.14 :D Should I create a PR or does it make sense that you do it? |
I skipped mentioning the update of mimir, because generally none of the previous chart's versions did that. Now as you mention it, we must record the changes of mimir (and GEM) versions. Please open a PR with the fix. |
|
Sure, does that work for you #9621 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This is a fixup to #9591 where I forgot to update the final version number in the Helm chart's changelog.
Which issue(s) this PR fixes or relates to
Relates to ##9382